Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3087 Adding shop=dairy #3127

Merged
merged 2 commits into from
Mar 18, 2018
Merged

Conversation

james2432
Copy link
Contributor

@james2432 james2432 commented Mar 17, 2018

@kocio-pl
Copy link
Collaborator

There are several key words to automatically close related issues:

https://help.github.com/articles/closing-issues-using-keywords/

@james2432
Copy link
Contributor Author

I was aware of the keywords, didn't want to assume anything though

@kocio-pl
Copy link
Collaborator

Thanks. It's a standard procedure to close the issues like that - of course if the code really resolves the problem, but this is typically true for "add key=value" issues.

@james2432
Copy link
Contributor Author

Merge issues fixed

@kocio-pl kocio-pl changed the title Issue #3087 Adding shop=diary Issue #3087 Adding shop=dairy Mar 17, 2018
@kocio-pl kocio-pl merged commit 245f7ef into gravitystorm:master Mar 18, 2018
@kocio-pl
Copy link
Collaborator

Thanks, it works as advertised.

@james2432 james2432 deleted the shop_dairy branch March 18, 2018 13:06
james2432 added a commit to james2432/openstreetmap-carto that referenced this pull request Mar 18, 2018
james2432 added a commit to james2432/openstreetmap-carto that referenced this pull request Mar 18, 2018
james2432 added a commit to james2432/openstreetmap-carto that referenced this pull request Mar 18, 2018
james2432 added a commit to james2432/openstreetmap-carto that referenced this pull request Mar 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants